Repository navigation
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
ament_target_dependencies() was deprecated in Kilted (ament/ament_cmake#572) and removed in Rolling / Lyrical (ament/ament_cmake#614), so abb_hardware_interface, abb_rws_client and the abb_bringup tests fail to configure with "Unknown CMake command". Link the exported CMake targets directly instead. abb_hardware_interface only exports old-style variables, so abb_rws_client uses abb_hardware_interface_LIBRARIES / _INCLUDE_DIRS for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ros2_control replaced on_init(const HardwareInfo&) with on_init(const HardwareComponentInterfaceParams&), so the override no longer compiles. The body keeps using info_, which the base class still populates from params.hardware_info. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yishinli
force-pushed
the
fix/rolling-build
branch
from
October 26, 2026 04:58
434a8ca to
b623a2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
abb_ros2no longer builds on current ROS 2 (Rolling / Lyrical):abb_rws_clientlinksabb_hardware_interfaceviaabb_hardware_interface_LIBRARIES/_INCLUDE_DIRS, since that package only exports old-style variables.Evidence
Before (ROS 2 Lyrical, Ubuntu 26.04):
After: the full workspace from
abb.reposbuilds with colcon (together with ros-industrial/abb_libegm#172 and ros-industrial/abb_egm_rws_managers#16 for Boost 1.90). An IRB 4600 withuse_fake_hardware:=true,joint_trajectory_controllerand MoveIt 2 plans and executes OMPL and Pilz LIN trajectories.The
Build and Testworkflow onrollingcurrently stops before building, insetup_rosdep(E: Unable to locate package ros-rolling-ros-environment), so CI on this PR will fail the same way until that is sorted out. Sinceabb.repospoints abb_libegm and abb_egm_rws_managers atmaster, Rolling CI will also need ros-industrial/abb_libegm#172 and ros-industrial/abb_egm_rws_managers#16 to be merged.Merge Danger
Door: two-way
Blast Radius: build-only
target_link_librarieswith these targets works on all ROS 2 distros, andon_init(const HardwareComponentInterfaceParams&)is available in ros2_control since 4.34.0 (Jazzy) and 5.3.0 (Kilted), where theHardwareInfooverload is deprecated. Building this branch against an older ros2_control release would fail.🤖 Generated with Claude Code