Repository navigation
Commit 3585bf8
committed
fix(owen): close two Codex-flagged holes in the rebrand (PR #246)
- CoreVendor's legacy ~/.ownsharp fallback trusted a bare .unpacked
marker's existence keyed only by version. The CLI's own <Version>
doesn't change every time the vendored core's content does - this
rebrand's own SARIF-driver-name change is the concrete proof: same
0.1.0, different core content - so a machine with a pre-rebrand
OwnSharp.Cli install's ~/.ownsharp/core/0.1.0/ cache could silently
serve stale content (the old "Own.NET" driver name) to the new
Owen.Cli 0.1.0 install. Reproduced locally: seeded a legacy cache
with the pre-rebrand driver name and confirmed `owen check --format
sarif` served it unchanged before this fix.
Fixed by keying the marker on a SHA-256 fingerprint of the bundled
ownlang/*.py files' names+content instead of bare existence - same
location, both the new ~/.owen and legacy ~/.ownsharp fallback
checks now only trust a cache whose marker matches the content this
install actually bundles. Still the "simple fallback read, not a
migration subsystem" shape requested - content-aware instead of
version-only. Verified both directions locally: a stale-content
legacy cache is now correctly rejected (fresh unpack to ~/.owen),
and a legitimate matching-content legacy cache is still reused in
place without an unnecessary ~/.owen copy.
- CheckCommand.HasSupportedInput's directory walk used a plain
SearchOption.AllDirectories, which throws on a locked/permission-
denied subdirectory, while the extractor's own Expand() walk
(OwnSharp.Extractor/Program.cs) uses EnumerationOptions {
IgnoreInaccessible = true } specifically to tolerate that and keep
scanning. The new preflight check could have crashed owen check on
a directory tree the extractor itself would have handled fine.
Fixed by using the identical EnumerationOptions the extractor
already relies on.
docs/notes/owen-public-facade.md updated to record both corrections
in place, without erasing the original description of the intended
(simpler, buggier) fallback shape.1 parent 377a7b1 commit 3585bf8
3 files changed
Lines changed: 87 additions & 27 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
97 | 104 | | |
98 | 105 | | |
99 | 106 | | |
100 | 107 | | |
101 | 108 | | |
102 | 109 | | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
109 | 127 | | |
110 | 128 | | |
111 | 129 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
161 | 172 | | |
162 | 173 | | |
163 | 174 | | |
| |||
172 | 183 | | |
173 | 184 | | |
174 | 185 | | |
175 | | - | |
| 186 | + | |
176 | 187 | | |
177 | 188 | | |
178 | 189 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
1 | 4 | | |
2 | 5 | | |
3 | 6 | | |
| |||
8 | 11 | | |
9 | 12 | | |
10 | 13 | | |
11 | | - | |
12 | | - | |
13 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
14 | 18 | | |
15 | 19 | | |
16 | 20 | | |
| |||
22 | 26 | | |
23 | 27 | | |
24 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
25 | 49 | | |
26 | 50 | | |
27 | 51 | | |
28 | 52 | | |
29 | | - | |
| 53 | + | |
30 | 54 | | |
31 | 55 | | |
32 | 56 | | |
33 | 57 | | |
34 | 58 | | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
| 59 | + | |
| 60 | + | |
39 | 61 | | |
40 | 62 | | |
41 | | - | |
| 63 | + | |
42 | 64 | | |
43 | 65 | | |
44 | 66 | | |
45 | 67 | | |
46 | 68 | | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | 69 | | |
57 | 70 | | |
58 | 71 | | |
| |||
62 | 75 | | |
63 | 76 | | |
64 | 77 | | |
65 | | - | |
| 78 | + | |
66 | 79 | | |
67 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
68 | 99 | | |
0 commit comments