Repository navigation
Commit 377a7b1
committed
feat(owen): public facade rebrand for the CLI, Action, and SARIF identity
Public product identity is "Owen" going forward - a package published
as "OwnSharp.Cli" with the permanent command "ownsharp" would have
locked the public identity to a single-language framing the project
doesn't actually have (Own.NET is language-neutral at the OwnIR/core
level and may ship a TypeScript frontend later). This is a public
facade rebrand, not an internal refactor - see
docs/notes/owen-public-facade.md for the full account of what changed
and, just as deliberately, what did not.
Public identity implemented:
- NuGet package ID: OwnSharp.Cli -> Owen.Cli (confirmed unclaimed on
nuget.org at time of writing via the v3 flat-container API)
- Tool command: ownsharp -> owen
- Action display name: "Own.NET resource-leak check" -> "Owen
lifetime/resource check"; default SARIF filename own-net.sarif ->
owen.sarif
- SARIF tool.driver.name: "Own.NET" -> "Owen" (ownlang/ownir.py +
ownlang/diag_sarif.py - the one place both the C#-facts and the
.own-diagnostics SARIF paths share)
- Cache directory: ~/.ownsharp/core/<version>/ -> ~/.owen/core/<version>/,
with a simple fallback read (not a migration subsystem) from the
previous location if a matching version was already unpacked there
- Env var: OWEN_PYTHON preferred; legacy OWN_PYTHON still works as a
temporary fallback and prints a deprecation note when it's the one
actually used
Kept unchanged (internal names, not mass-renamed): the OwnSharp.Cli
project/namespace, OwnSharp.Extractor (project + its real
ownsharp-extract.dll output filename), ownlang (package/module names,
CLI, PYTHONPATH conventions), OwnIR, every OWN0xx diagnostic code, the
Rust crates, every frontend/* directory name, historical docs/issues,
the GitHub repo name, and scripts/own-check.sh (the Action still calls
it internally). AssemblyName in the csproj stays "ownsharp" - it names
the internal dll the owen shim launches, never seen by a user, so
renaming it adds no user value.
CLI contract additions:
- `owen --help` is language-neutral at the product level while
explicitly listing the one frontend actually wired in today
("Included frontend: .NET / C# (.cs, .csproj, .sln)") - no
speculative TypeScript claim, no plugin framework added.
- Unsupported input (e.g. a .ts file, or a directory with no .cs
files) now fails explicitly with a new exit code 4 and an explicit
message, instead of silently printing "0 findings" - indistinguishable
from a genuinely clean C# scan before this change.
CheckCommand.HasSupportedInput checks this before the extractor runs.
Tests: ci.yml's ownsharp-cli-smoke job (key kept; only content changed)
now pins package ID, command name, --help framing, --version, the
unknown-command "owen:" prefix, a leak sample and a clean negative
control both run from an installed checkout-free location, the Owen
SARIF driver name, the exit-4 unsupported-input path (asserting the
literal clean-scan phrase "0 findings." does NOT appear), OWEN_PYTHON's
not-found path, and the legacy OWN_PYTHON fallback + its deprecation
note - on both ubuntu-latest and windows-latest. Every one of these
assertions was manually replicated and verified on this machine before
being written into the workflow. Two other pre-existing SARIF
driver-name assertions (ci.yml's own-check-codescan structural
validation, tests/test_diag_sarif.py, tests/test_ownir.py) were updated
to match "Owen" - caught by python tests/run_tests.py failing before
the fix, not scope creep.
PR separation: this is PR 1 of 3. Phase 3 (NuGet release pipeline, PR
#244) and Phase 4 (Marketplace preparation, PR #245) both need to be
rebuilt against this PR once merged, targeting Owen.Cli/owen and the
Owen display name instead of the pre-rebrand identity their first
drafts used. No oracle remeasurement or analyzer-semantics change is
mixed into this PR.1 parent 4c5a86b commit 377a7b1
17 files changed
Lines changed: 519 additions & 130 deletions
File tree
- .github/workflows
- docs/notes
- frontend/roslyn/OwnSharp.Cli
- ownlang
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1717 | 1717 | | |
1718 | 1718 | | |
1719 | 1719 | | |
1720 | | - | |
| 1720 | + | |
1721 | 1721 | | |
1722 | 1722 | | |
1723 | 1723 | | |
1724 | 1724 | | |
1725 | 1725 | | |
1726 | 1726 | | |
1727 | | - | |
1728 | | - | |
| 1727 | + | |
| 1728 | + | |
1729 | 1729 | | |
1730 | 1730 | | |
1731 | 1731 | | |
| |||
1739 | 1739 | | |
1740 | 1740 | | |
1741 | 1741 | | |
1742 | | - | |
| 1742 | + | |
1743 | 1743 | | |
1744 | 1744 | | |
1745 | 1745 | | |
| |||
1942 | 1942 | | |
1943 | 1943 | | |
1944 | 1944 | | |
1945 | | - | |
| 1945 | + | |
| 1946 | + | |
| 1947 | + | |
| 1948 | + | |
1946 | 1949 | | |
1947 | 1950 | | |
1948 | 1951 | | |
1949 | 1952 | | |
1950 | 1953 | | |
1951 | 1954 | | |
1952 | 1955 | | |
1953 | | - | |
| 1956 | + | |
1954 | 1957 | | |
1955 | 1958 | | |
1956 | 1959 | | |
| |||
1959 | 1962 | | |
1960 | 1963 | | |
1961 | 1964 | | |
1962 | | - | |
| 1965 | + | |
1963 | 1966 | | |
1964 | 1967 | | |
1965 | 1968 | | |
| |||
1976 | 1979 | | |
1977 | 1980 | | |
1978 | 1981 | | |
1979 | | - | |
1980 | | - | |
1981 | | - | |
| 1982 | + | |
| 1983 | + | |
| 1984 | + | |
| 1985 | + | |
| 1986 | + | |
| 1987 | + | |
| 1988 | + | |
| 1989 | + | |
| 1990 | + | |
| 1991 | + | |
| 1992 | + | |
| 1993 | + | |
| 1994 | + | |
| 1995 | + | |
| 1996 | + | |
| 1997 | + | |
| 1998 | + | |
| 1999 | + | |
| 2000 | + | |
| 2001 | + | |
1982 | 2002 | | |
1983 | 2003 | | |
1984 | 2004 | | |
1985 | | - | |
1986 | | - | |
| 2005 | + | |
| 2006 | + | |
1987 | 2007 | | |
1988 | 2008 | | |
1989 | 2009 | | |
| |||
1994 | 2014 | | |
1995 | 2015 | | |
1996 | 2016 | | |
| 2017 | + | |
| 2018 | + | |
| 2019 | + | |
| 2020 | + | |
| 2021 | + | |
| 2022 | + | |
| 2023 | + | |
| 2024 | + | |
| 2025 | + | |
| 2026 | + | |
| 2027 | + | |
| 2028 | + | |
| 2029 | + | |
| 2030 | + | |
1997 | 2031 | | |
1998 | 2032 | | |
1999 | | - | |
2000 | | - | |
2001 | | - | |
| 2033 | + | |
| 2034 | + | |
| 2035 | + | |
| 2036 | + | |
| 2037 | + | |
| 2038 | + | |
| 2039 | + | |
| 2040 | + | |
| 2041 | + | |
| 2042 | + | |
| 2043 | + | |
| 2044 | + | |
| 2045 | + | |
| 2046 | + | |
| 2047 | + | |
| 2048 | + | |
| 2049 | + | |
| 2050 | + | |
| 2051 | + | |
| 2052 | + | |
| 2053 | + | |
| 2054 | + | |
| 2055 | + | |
| 2056 | + | |
| 2057 | + | |
| 2058 | + | |
| 2059 | + | |
2002 | 2060 | | |
2003 | 2061 | | |
2004 | | - | |
| 2062 | + | |
2005 | 2063 | | |
2006 | 2064 | | |
2007 | 2065 | | |
2008 | 2066 | | |
2009 | 2067 | | |
| 2068 | + | |
| 2069 | + | |
| 2070 | + | |
| 2071 | + | |
| 2072 | + | |
| 2073 | + | |
| 2074 | + | |
| 2075 | + | |
| 2076 | + | |
| 2077 | + | |
| 2078 | + | |
| 2079 | + | |
| 2080 | + | |
| 2081 | + | |
| 2082 | + | |
| 2083 | + | |
| 2084 | + | |
| 2085 | + | |
| 2086 | + | |
| 2087 | + | |
| 2088 | + | |
| 2089 | + | |
| 2090 | + | |
| 2091 | + | |
| 2092 | + | |
| 2093 | + | |
| 2094 | + | |
| 2095 | + | |
| 2096 | + | |
| 2097 | + | |
| 2098 | + | |
| 2099 | + | |
| 2100 | + | |
2010 | 2101 | | |
2011 | 2102 | | |
2012 | 2103 | | |
| |||
2015 | 2106 | | |
2016 | 2107 | | |
2017 | 2108 | | |
2018 | | - | |
| 2109 | + | |
2019 | 2110 | | |
2020 | 2111 | | |
2021 | | - | |
| 2112 | + | |
2022 | 2113 | | |
2023 | 2114 | | |
2024 | 2115 | | |
2025 | 2116 | | |
2026 | | - | |
| 2117 | + | |
2027 | 2118 | | |
| 2119 | + | |
| 2120 | + | |
| 2121 | + | |
| 2122 | + | |
| 2123 | + | |
| 2124 | + | |
| 2125 | + | |
| 2126 | + | |
| 2127 | + | |
| 2128 | + | |
| 2129 | + | |
| 2130 | + | |
2028 | 2131 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
31 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| |||
921 | 922 | | |
922 | 923 | | |
923 | 924 | | |
924 | | - | |
| 925 | + | |
925 | 926 | | |
926 | 927 | | |
927 | 928 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | | - | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
91 | | - | |
| 91 | + | |
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
| 98 | + | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
| 110 | + | |
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
| |||
0 commit comments