Rework logger#338
Open
thomaswilliamsastro wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #338 +/- ##
=========================================
- Coverage 6.27% 6.22% -0.06%
=========================================
Files 38 38
Lines 15229 15192 -37
Branches 3653 3649 -4
=========================================
- Hits 955 945 -10
+ Misses 14260 14233 -27
Partials 14 14 ☔ View full report in Codecov by Sentry. |
thomaswilliamsastro
force-pushed
the
rework-logging
branch
3 times, most recently
from
d41d99a to
3d3c0d9
Compare
Collaborator
Author
|
@low-sky this is now ready for review! |
thomaswilliamsastro
force-pushed
the
rework-logging
branch
3 times, most recently
from
419f689 to
6123dcd
Compare
- Remove deprecated pipelineLogger module - Tidy up phangsLogger.py - Tidy up the log format to be consistent and more informative - Add test suite - Remove debug call throughout - Add changelog entry
thomaswilliamsastro
force-pushed
the
rework-logging
branch
from
6123dcd to
7ffea32
Compare
Collaborator
Author
|
@low-sky any showstoppers on this, or are we good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks logging, to make the output more useful. It'll now overwrite the file if a log output is selected, and the default log format is synchronised between terminal and file. It now looks like this (by default, but can be customised):
The pipelineLogger, which was never used anywhere, has now been removed. Finally, there are also now tests that cover the whole logger, and the pipeline doesn't force default to
DEBUG.