Windows: plz build and test --shell checked on a real machine - #7
Merged
Merged
Conversation
…with slashes --shell had never been exercised on Windows. Under Wine it works, with and without =run, for builds and tests: busybox opens in the target's directory with its environment set. The one defect was the directory printed above it, which for a test came out backslash-separated and so could not be pasted into that shell. Adds Wine tests for both forms and native probes for the Windows job. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AaLmkJrkt7eRJC9uPXvbKe
Check plz build and test --shell on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings in #6.
plz build --shellandplz test --shell, both with and without=run, are now tested on Windows: under Wine by//test/windows:shell_run_testand:interactive_shell_test, and onwindows-latestby new probes inrun_native_probes.ps1. All passed in Check plz build and test --shell on Windows #6's CI run.07-state-of-play.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01AaLmkJrkt7eRJC9uPXvbKe