Repository navigation
docs: clarify remediation for published security advisories - #12180
Merged
proggeramlug merged 2 commits intoOct 8, 2026
Merged
Conversation
jdalton
marked this pull request as ready for review
October 8, 2026 00:47
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impact
Give users a private vulnerability reporting path and clear upgrade guidance for both published advisories. GitHub can detect the new root SECURITY.md instead of displaying “No security policy detected.”
Before → after
Investigation
Both vulnerabilities already have fixes on main. Publish validates artifact names and only permits server-provided local paths from loopback hubs (#4989). JWT expiry enforcement landed in #5008; the duplicate extension fix followed in #5072, and both native JWT implementations were subsequently removed in #10687 in favor of compiling the npm package.
These are published historical advisories, not unresolved code alerts. A PR cannot remove their cards or change advisory metadata. This PR documents the existing remediation and fixes the missing security policy; it does not claim a new runtime security fix.
Validation
Reviewed the advisory patched-version metadata and current publish sanitization/local-hub gate, including the existing traversal and loopback regression tests. Confirmed GitHub private vulnerability reporting is enabled. Documentation-only change; no runtime tests run.