Repository navigation
fix(runtime): a class function object keeps its evaluation state and prototype link in separate captures (main build) - #11847
Merged
Conversation
…its prototype link in separate captures #11840 put the evaluation state in capture 1 of the class function object and #11843 put the prototype link there too; the merge left conflict markers in class_value.rs and main does not compile. The evaluation state keeps capture 1 (codegen writes it at CLASS_EVALUATION_STATE_CAPTURE); the prototype link moves to capture 2, and the object is minted with three captures. Const asserts keep the two slots apart.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main does not compile since #11843 merged: #11840 put the class function object's evaluation state in capture 1 and #11843 put the prototype link in capture 1 too, and the merge committed the conflict markers in
crates/perry-runtime/src/object/class_value.rs.CLASS_EVALUATION_STATE_CAPTURE).Verified on perrymaster: release build of perry + runtime/stdlib OK,
cargo fmt --checkOK; the 16 class-evaluation / fresh-class gap and parity tests (11759*,11042,11112,11163,10624,9239, class-expression fresh tests) match node; the vtable lane benches match node.Not fixed here (pre-existing, separate): conflict markers in
scripts/gc_runtime_root_holders.json(a PASS1_MARKED re-audit pin with source hashes; it needs a real re-audit).Summary by CodeRabbit