You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
this is undefined inside a do…while body in non-class functions (breaks node-forge rsa_sign) #11724
Found by the package matrix re-run (#11723): node-forge/rsa_sign throws TypeError: … (reading 'data'). Reproduces 3/3 at 9e29f59 and on origin/main 9e05951.
Inside a do…while body, this is undefined in any non-class function. A plain while loop works, and so does a class method.
Hint for whoever picks this up: a fix attempt that was stopped part-way traced it to two separate statement walkers that don't handle do…while bodies the same way (likely the this/captures analysis after #11637 made this a body parameter). The planned fix was to replace both walkers with one exhaustive helper, so no statement kind can be missed. Please also check for/for-in/for-of/labeled loops/continue paths, and arguments/new.target inside do-while. Acceptance: the repro matches Node, and node-forge/rsa_sign passes (scripts/package_bench.py, benchmarks/packages).
Activity
proggeramlug commentedon Oct 1, 2026
Hint for whoever picks this up: a fix attempt that was stopped part-way traced it to two separate statement walkers that don't handle
do…whilebodies the same way (likely thethis/captures analysis after #11637 madethisa body parameter). The planned fix was to replace both walkers with one exhaustive helper, so no statement kind can be missed. Please also checkfor/for-in/for-of/labeled loops/continuepaths, andarguments/new.targetinside do-while. Acceptance: the repro matches Node, and node-forge/rsa_sign passes (scripts/package_bench.py, benchmarks/packages).