pretty please add my nodes extension#573
Conversation
Added basic documentation for the Node System with usage instructions.
Added a brief introduction and example code for the Node System.
Added a new node system extension with relevant details.
Removed unused variables 'menus' and 'nextId' from nodes.js.
Refactor unlinkNodes method to use filter instead of for loop.
Steve0Greatness
left a comment
Steve0Greatness
left a comment
There was a problem hiding this comment.
The indenting is a bit of a mess. I'd probably run this through some kind of formatter as it's kinda hard to read.
RedMan13
left a comment
RedMan13
left a comment
There was a problem hiding this comment.
Pretty pretty pretty please make it so links and nodes can be tracked directly, right now theres no way from this extension to see which nodes are linked where, nor easily follow those links in any meaningful way
| switch (String(args.DIR)) { | ||
| case "right": | ||
| x += 1; | ||
| break; | ||
| case "left": | ||
| x -= 1; | ||
| break; | ||
| case "up": | ||
| y += 1; | ||
| break; | ||
| case "down": | ||
| y -= 1; | ||
| break; | ||
| } |
There was a problem hiding this comment.
this fails if the nodes arent exclusively one-away from each other and perfectly on grid with eachother, maybe instead limit it to only forward and backward? or compute the angle to each node and find the one closest to an angle the user inputs.
There was a problem hiding this comment.
this fails if the nodes arent exclusively one-away from each other and perfectly on grid with eachother, maybe instead limit it to only
forwardandbackward? or compute the angle to each node and find the one closest to an angle the user inputs.
or really actually, maybe just move this to links? that way it can be a link follower instead, which would be far more handy
There was a problem hiding this comment.
thisnisnt resolved, please actually engage before resolving
Refactor link removal logic to use filter method.
Removed unnecessary comment from unlinkNodes method.
Added documentation field to Nodes entry.
Removed unnecessary comment about extra commas in JSON.
Removed unnecessary introduction section from documentation.
Steve0Greatness
left a comment
Steve0Greatness
left a comment
There was a problem hiding this comment.
Maybe the documentation needs a bit more work, but this is definitely better.
Steve0Greatness
left a comment
Steve0Greatness
left a comment
There was a problem hiding this comment.
Seems like all the issues I had with this have been fixed.
|
Pretty cool extension, would be better if it used objects and arrays instead of json though |
|
and also a way to load nodes/connections from an array too would be nice |
|
I think it already uses arrays and objects to begin with... and you can use the backpack feature in the penguinmod editor or make a custom block to save your stuff. I need to look into the second one though. |
|
I can tell you the 2nd one is false, the backpack only saves the blocks/sprite/costume/sound and the extension(s) themselves with no ext data saved |
|
then you have to import the extension back
…On Tue, May 12, 2026 at 5:45 PM AndrewScripter587 ***@***.***> wrote:
*AndrewScripter587* left a comment
(PenguinMod/PenguinMod-ExtensionsGallery#573)
<#573 (comment)>
I can tell you the 2nd one is false, the backpack only saves the
blocks/sprite/costume/sound and the extension(s) themselves with no ext
data saved
—
Reply to this email directly, view it on GitHub
<#573 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNIFNK64YMS2MBYNKXTV72L42OLOZAVCNFSM6AAAAACYXVKWXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DIMZVGA4DIMBYHA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
6 participants
its really cool trust!!!
fix if its broken tho...