Fix: Camera switching latency issue#161
Open
Manu3lde wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves camera device selection and video stream handling. Fixes issues when switching cameras and safely applies video track constraints.
changes
(
deviceButton.tsx)Stops previous stream tracks before switching, removes
facingModewhendeviceIdis used, adds fallback to default constraints on error, listens todevicechangefor dynamic updates, syncs dropdown state with active track, and handles missing labels.(
video.tsx)Adds type-safe zoom constraints, checks existence of
videoRef.currentandsrcObjectbefore accessing capabilities, restructures cleanup to properly await track stop, and applies constraints immediately + after 500ms (instead of a fixed 2s timeout).Closes #159