Fix some buffs applying incorrectly to the player and minions#9789
Merged
LocalIdentity merged 3 commits intodevfrom Apr 20, 2026
Merged
Fix some buffs applying incorrectly to the player and minions#9789LocalIdentity merged 3 commits intodevfrom
LocalIdentity merged 3 commits intodevfrom
Conversation
added 3 commits
April 20, 2026 20:36
PR #9676 added code to allow the support gem to grant a global effect but this had the effect of scaling other global effects by the number of skills in the build and was ignoring their effect conditions e.g. Ancient Skull 50% inc damage was applying 20 times to player skills in a build
Stops Ichimonjji from blocking their effect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9783, Fixes #9791
Description of the problem being solved:
Fixes an issue where some global effect buffs were applying for each skill gem in the build
This fix is more temporary until we properly handle Hallowing Flame
Fixes Farrul beast Auras being disabled by Ichimonji
Fixes Flicker Strike's movement speed buff stacking if you had both Flicker Strike and Flicker Strike of Power
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/eu47zf0s
Before screenshot:
After screenshot: