Skip to content

[pob1-port] Remove alternate quality code #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 2 commits into from
Apr 25, 2026
+1 −14
Merged

[pob1-port] Remove alternate quality code #1794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
430706f
Apply changes from https://github.com/PathOfBuildingCommunity/PathOfB…
LocalIdentity Apr 14, 2026
71f53dd
Fix conflicts
Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/Classes/GemSelectControl.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,6 @@ function GemSelectClass:PopulateGemList()
end
end

function GemSelectClass:GetQualityType(gemId)
return gemId and gemId:gsub(":.+","") or "Default"
end

function GemSelectClass:FilterSupport(gemId, gemData)
local showSupportTypes = self.skillsTab.showSupportGemTypes
return (not gemData.grantedEffect.support
Expand Down Expand Up @@ -354,7 +350,7 @@ function GemSelectClass:UpdateGem(setText, addUndo)
if setText then
self:SetText(self.gemName)
end
self.gemChangeFunc(self.gemId and self.gemId:gsub("%w+:", ""), self:GetQualityType(self.gemId), addUndo and self.gemName ~= self.initialBuf)
self.gemChangeFunc(self.gemId and self.gemId:gsub("%w+:", ""), addUndo and self.gemName ~= self.initialBuf)
end

function GemSelectClass:ScrollSelIntoView()
Expand Down
7 changes: 0 additions & 7 deletions src/Classes/SkillsTab.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,6 @@ local sortGemTypeList = {
{ label = "Effective Hit Pool", type = "TotalEHP" },
}

local alternateGemQualityList ={
{ label = "Default", type = "Default" },
{ label = "Anomalous", type = "Alternate1" },
{ label = "Divergent", type = "Alternate2" },
{ label = "Phantasmal", type = "Alternate3" },
}

local SkillsTabClass = newClass("SkillsTab", "UndoHandler", "ControlHost", "Control", function(self, build)
self.UndoHandler()
self.ControlHost()
Expand Down
2 changes: 0 additions & 2 deletions src/Modules/CalcSetup.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1585,7 +1585,6 @@ function calcs.initEnv(build, mode, override, specEnv)
grantedEffect = grantedEffect,
level = gemInstance.level,
quality = gemInstance.quality,
qualityId = gemInstance.qualityId,
srcInstance = gemInstance,
gemData = gemInstance.gemData,
superseded = false,
Expand Down Expand Up @@ -1655,7 +1654,6 @@ function calcs.initEnv(build, mode, override, specEnv)
grantedEffect = grantedEffect,
level = gemInstance.level,
quality = gemInstance.quality,
qualityId = gemInstance.qualityId,
srcInstance = gemInstance,
gemData = gemInstance.gemData,
}
Expand Down
Loading