Just Taking a look - #1
Open
PassivePicasso wants to merge 35 commits into
Open
Conversation
branch. Comment out and annotate broken/unused iteams that needs more evaluation before cleanup. I'm not sure if there is some required implicit behavior that happens in these, so keep them for reference until the processes are actually fixed. Potential process fix for RemoveAllBundleAssets (untested)
I'm adding these separately to be easier to remove from git history later. I don't want the full dependency tree, but for now it's the easiest way to make things work.
Add tooltips for input fields.
Most of the functionality is working at this point.
the infos were). Whoops. Fix that and remove the last references to the assetsReplacers list. Loading the bundle now tends to crash unity now that it has actual data to parse, but will work on that.
that they don't clutter the debugger window when not releavant.
…r bundle container from scratch. WIP work to create the bundle's inner AssetsFile from scratch as well. (This happens to smooth over problems with the provided template for now.)
representation until it's actually needed. This simplifies keeping track of when to generate the replacer and the associated AssetFileInfo, while potentially reducing peak memory usage when writing files.
…aph entrypoint and doing a graph walk.
This speeds things up a lot.
…he bundle template.
There are still some more arrays like this, so working on a more generic solution.
to fix issues with missing dependencies on objects not specifically requested.
Add branding to the catalog json name to make conflicts less likely.
The tree is large, and it only has few m_PathIDs that seem to be related to the source project.
Separate filtering concern a bit from dependency gathering, and rework it. Avoid full graph walk for dependency-only objects. Their dependency graphs are subgraphs for the root objects graphs, so we only need enough information to remap their PPtrs.
If an object like Transform is added as a sub-object, unity can consider it orphaned and destroy it, which invalidates the object that uses it. That kind of problem may need to be fixed in the importer eventually, but removing objects we didn't want to browse anyway reduces the problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.