Repository navigation
📝 Document baggage propagation behavior on receive - #8519
Draft
ramonsmits wants to merge 2 commits into
Draft
ramonsmits wants to merge 2 commits into
ramonsmits wants to merge 2 commits into
Conversation
Describes how NServiceBus applies the baggage header to the process span: only together with NServiceBus trace context, also when a transport SDK receive span is the parent (the Azure Service Bus, RabbitMQ, and Amazon SQS clients do not propagate baggage), without re-adding a key the SDK span already carries, and regardless of whether a new trace is started. Adds usage guidance and clarifies the baggage header on the headers page.
…ry Baggage API Activity.Baggage and OpenTelemetry.Baggage are separate stores. Neither one reads the other. A user who sets baggage through the OpenTelemetry API gets no baggage header on the message, because NServiceBus reads Activity.Baggage. Links the community OpenTelemetry .NET instrumentation reference for the difference between the two APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #8443. Documents the receive-side baggage behavior introduced on the NServiceBus
otelbranch (Particular/NServiceBus#7954).What is documented
baggageheader and applies it to the process span on receive, on every transport.tracestateare read only from messages that also carryNServiceBus.TraceParentortraceparent.Files
nservicebus/operations/opentelemetry_traces_core_[10,11).partial.mdand[11,).partial.md: newBaggagesubsection underContext propagation.nservicebus/messaging/headers.md: annotate thebaggageheader, add the receive-side rule for 10.3 and later, and remove a stray empty list item.