Skip to content

Remove upgrade protection enums - #3146

Draft
hazel-bohon wants to merge 4 commits into
masterfrom
remove-upgrade-protection-enums
Draft

hazel-bohon wants to merge 4 commits into
masterfrom
remove-upgrade-protection-enums

Conversation

@hazel-bohon

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • Components are broken down into sensible and maintainable sub-components.
  • Styles are scoped to the component using it. If multiple components need to share CSS, then a .css file is created containing the shared CSS and imported into component scoped style sections.
  • Naming is consistent with existing code, and adequately describes the component or function being introduced
  • Only functions utilizing Vue state or lifecycle hooks are named as composables (i.e. starting with 'use');
  • No module-level state is being introduced. If so, request the PR author to move the state to the corresponding Pinia store.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Existing scenarios will fail, and the new unsupported status produces misleading expiration messages.

Review effort: Balanced
Findings: 1 High severity · 2 Medium severity

Open (3)
What changed in this PR

Removes obsolete upgrade-protection license statuses and adopts the replacement unsupported-license status.

Changes:

  • Updates license state handling and notifications.
  • Removes obsolete upgrade-protection warnings and tests.
File Description
test/​preconditions/​licensing.ts Updates upgrade-protection fixtures.
stores/​LicenseStore.ts Revises status mapping and severity.
resources/​LicenseInfo.ts Replaces obsolete enum values.
components/​LicenseNotifications.vue Updates notification classification.
components/​LicenseNotifications.spec.ts Updates notification tests.
components/​LicenseNotificationPopup.vue Removes obsolete warning headings.
components/​configuration/​PlatformLicense.vue Removes obsolete warning content.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

break;
case LicenseType.UpgradeProtection:
status = isExpired ? LicenseStatus.InvalidDueToExpiredUpgradeProtection : LicenseStatus.ValidWithExpiringUpgradeProtection;
status = LicenseStatus.InvalidDueToUpgradeProtectionNoLongerBeingSupported;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in cd246699. Replaced obsolete expiring-upgrade-protection scenarios with unsupported-license coverage for past, present, and future protection dates. Added an explicit unsupported fixture and restricted expiring/expired fixtures to trials and subscriptions. All 71 licensing/configuration tests pass.

case LicenseStatus.InvalidDueToExpiredTrial:
case LicenseStatus.InvalidDueToExpiredSubscription:
case LicenseStatus.InvalidDueToExpiredUpgradeProtection:
case LicenseStatus.InvalidDueToUpgradeProtectionNoLongerBeingSupported:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the notification to say upgrade-protection licenses are no longer supported, while preserving the expired-license copy for expired trial/subscription statuses. Added coverage; commit 06fdaf3b.

Comment thread src/Frontend/src/stores/LicenseStore.ts Outdated
licenseStatus.isInvalidDueToUpgradeProtectionExpired = license.license_status === LicenseStatus.InvalidDueToExpiredUpgradeProtection;
licenseStatus.isValidWithExpiredUpgradeProtection = license.license_status === LicenseStatus.ValidWithExpiredUpgradeProtection;
licenseStatus.isValidWithExpiringUpgradeProtection = license.license_status === LicenseStatus.ValidWithExpiringUpgradeProtection;
licenseStatus.isInvalidDueToUpgradeProtectionExpired = license.license_status === LicenseStatus.InvalidDueToUpgradeProtectionNoLongerBeingSupported;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in cd246699. Added isUpgradeProtectionUnsupported and renamed the aggregate blocking flag to isInvalid, preserving access restrictions. Updated the monitoring page, license details, and date suffix to describe unsupported licenses without claiming expiration.

Co-authored-by: hazel-bohon <2416062+hazel-bohon@users.noreply.github.com>
Co-authored-by: hazel-bohon <2416062+hazel-bohon@users.noreply.github.com>

Copilot AI commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Copilot review overview...

All findings are addressed: the popup fix remains in 06fdaf3b; the fixture/scenario and unsupported-state fixes are in cd246699. Validation passed: 71 tests, lint, type-check, build, secret scan, CodeQL, and fallback code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ValidWithExpiredUpgradeProtection

3 participants