Remove upgrade protection enums - #3146
hazel-bohon wants to merge 4 commits into
Conversation
…lidDueToUpgradeProtectionNoLongerBeingSupported value.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Existing scenarios will fail, and the new unsupported status produces misleading expiration messages.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Removes obsolete upgrade-protection license statuses and adopts the replacement unsupported-license status.
Changes:
- Updates license state handling and notifications.
- Removes obsolete upgrade-protection warnings and tests.
| File | Description |
|---|---|
test/preconditions/licensing.ts |
Updates upgrade-protection fixtures. |
stores/LicenseStore.ts |
Revises status mapping and severity. |
resources/LicenseInfo.ts |
Replaces obsolete enum values. |
components/LicenseNotifications.vue |
Updates notification classification. |
components/LicenseNotifications.spec.ts |
Updates notification tests. |
components/LicenseNotificationPopup.vue |
Removes obsolete warning headings. |
components/configuration/PlatformLicense.vue |
Removes obsolete warning content. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| break; | ||
| case LicenseType.UpgradeProtection: | ||
| status = isExpired ? LicenseStatus.InvalidDueToExpiredUpgradeProtection : LicenseStatus.ValidWithExpiringUpgradeProtection; | ||
| status = LicenseStatus.InvalidDueToUpgradeProtectionNoLongerBeingSupported; |
There was a problem hiding this comment.
Fixed in cd246699. Replaced obsolete expiring-upgrade-protection scenarios with unsupported-license coverage for past, present, and future protection dates. Added an explicit unsupported fixture and restricted expiring/expired fixtures to trials and subscriptions. All 71 licensing/configuration tests pass.
| case LicenseStatus.InvalidDueToExpiredTrial: | ||
| case LicenseStatus.InvalidDueToExpiredSubscription: | ||
| case LicenseStatus.InvalidDueToExpiredUpgradeProtection: | ||
| case LicenseStatus.InvalidDueToUpgradeProtectionNoLongerBeingSupported: |
There was a problem hiding this comment.
Updated the notification to say upgrade-protection licenses are no longer supported, while preserving the expired-license copy for expired trial/subscription statuses. Added coverage; commit 06fdaf3b.
| licenseStatus.isInvalidDueToUpgradeProtectionExpired = license.license_status === LicenseStatus.InvalidDueToExpiredUpgradeProtection; | ||
| licenseStatus.isValidWithExpiredUpgradeProtection = license.license_status === LicenseStatus.ValidWithExpiredUpgradeProtection; | ||
| licenseStatus.isValidWithExpiringUpgradeProtection = license.license_status === LicenseStatus.ValidWithExpiringUpgradeProtection; | ||
| licenseStatus.isInvalidDueToUpgradeProtectionExpired = license.license_status === LicenseStatus.InvalidDueToUpgradeProtectionNoLongerBeingSupported; |
There was a problem hiding this comment.
Fixed in cd246699. Added isUpgradeProtectionUnsupported and renamed the aggregate blocking flag to isInvalid, preserving access restrictions. Updated the monitoring page, license details, and date suffix to describe unsupported licenses without claiming expiration.
Co-authored-by: hazel-bohon <2416062+hazel-bohon@users.noreply.github.com>
Co-authored-by: hazel-bohon <2416062+hazel-bohon@users.noreply.github.com>
All findings are addressed: the popup fix remains in |


Reviewer Checklist