Tests for heartbeats - #3145
Merged
Merged
Tests for heartbeats#3145
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The added tests and helpers align with the existing heartbeat components and testing conventions.
Review effort: Balanced
Findings: None
What changed in this PR
Adds comprehensive heartbeat UI tests and reusable test helpers.
Changes:
- Covers heartbeat counts, listing, navigation, sorting, filtering, and refresh behavior.
- Adds reusable actions, queries, and endpoint fixtures.
- Expands configuration sorting coverage.
| File | Description |
|---|---|
questions/getListedEndpointNames.ts |
Reads listed endpoint names. |
questions/getHeartbeatsTabCount.ts |
Reads heartbeat tab counts. |
questions/getEndpointInstanceRows.ts |
Reads instance row details. |
questions/getColumnSortDirection.ts |
Detects active sort direction. |
configuring-heartbeats.spec.ts |
Tests configuration sorting. |
active-endpoints.spec.ts |
Tests active and inactive endpoint workflows. |
actions/sortEndpointsBy.ts |
Adds a sorting action. |
actions/navigateToHeartbeatsTabs.ts |
Tightens healthy-tab matching. |
actions/navigateToEndpointInstances.ts |
Adds instance navigation actions. |
preconditions/hasHeartbeatEndpoints.ts |
Adds heartbeat fixture helpers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
afprtclr
marked this pull request as ready for review
September 30, 2026 13:08
afprtclr
enabled auto-merge (squash)
September 30, 2026 13:08
mchamberlin77
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for heartbeats.
Implementation for https://github.com/Particular/PlatformInternals/issues/776
Reviewer Checklist