Skip to content

Tests for heartbeats - #3145

Merged
afprtclr merged 2 commits into
masterfrom
feature/776-heartbeats
Sep 30, 2026
Merged

afprtclr merged 2 commits into
masterfrom
feature/776-heartbeats

Conversation

@afprtclr

@afprtclr afprtclr commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Tests for heartbeats.
Implementation for https://github.com/Particular/PlatformInternals/issues/776

Reviewer Checklist

  • Components are broken down into sensible and maintainable sub-components.
  • Styles are scoped to the component using it. If multiple components need to share CSS, then a .css file is created containing the shared CSS and imported into component scoped style sections.
  • Naming is consistent with existing code, and adequately describes the component or function being introduced
  • Only functions utilizing Vue state or lifecycle hooks are named as composables (i.e. starting with 'use');
  • No module-level state is being introduced. If so, request the PR author to move the state to the corresponding Pinia store.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The added tests and helpers align with the existing heartbeat components and testing conventions.

Review effort: Balanced
Findings: None

What changed in this PR

Adds comprehensive heartbeat UI tests and reusable test helpers.

Changes:

  • Covers heartbeat counts, listing, navigation, sorting, filtering, and refresh behavior.
  • Adds reusable actions, queries, and endpoint fixtures.
  • Expands configuration sorting coverage.
File Description
questions/​getListedEndpointNames.ts Reads listed endpoint names.
questions/​getHeartbeatsTabCount.ts Reads heartbeat tab counts.
questions/​getEndpointInstanceRows.ts Reads instance row details.
questions/​getColumnSortDirection.ts Detects active sort direction.
configuring-heartbeats.spec.ts Tests configuration sorting.
active-endpoints.spec.ts Tests active and inactive endpoint workflows.
actions/​sortEndpointsBy.ts Adds a sorting action.
actions/​navigateToHeartbeatsTabs.ts Tightens healthy-tab matching.
actions/​navigateToEndpointInstances.ts Adds instance navigation actions.
preconditions/​hasHeartbeatEndpoints.ts Adds heartbeat fixture helpers.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@afprtclr
afprtclr marked this pull request as ready for review September 30, 2026 13:08
@afprtclr
afprtclr enabled auto-merge (squash) September 30, 2026 13:08
@afprtclr
afprtclr merged commit d79e09e into master Sep 30, 2026
6 checks passed
@afprtclr
afprtclr deleted the feature/776-heartbeats branch September 30, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants