Fix "Retry all" on pending retries requesting an empty date range - #3142
Merged
Merged
Conversation
Fixes a bug where `retryAll` was sending epoch zero as the date range instead of the actual selected period. Also removes `shallowReadonly` from `selectedQueue` to allow it to be mutated from outside the store where needed.
PhilBastian
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Retry all" on the Pending Retries view sent both
fromandtoasnew Date(0), so ServiceControl received an empty range in 1970 and retried nothing, while the UI still marked every row as submitted for retry. The bug goes back to the Vue migration (#1367): the AngularJS service sent epoch to now, and the migration transcribed thetoas epoch too.retryAllnow recomputes the date range from the selected period at click time and sends that, so the request also honors the period filter the same way the list does, which matches the old AngularJS behaviour.Testing this through the UI surfaced a second bug. #2685 exposed
selectedQueuefrom the store asshallowReadonly, but the queue dropdown writes to it through astoreToRefsv-model. Vue silently drops writes to a readonly ref, so selecting a queue never reached the store: the list never filtered by queue and "Retry all" always showed the "Select a queue first" dialog. Removing the wrapper makes the dropdown work again.New driver tests in
retrying-all-pending-retries.spec.tscover the flow end to end: clicking Retry all without a queue shows the notice and sends no request, with a queue selected the request carries the queue address and the displayed period range up to now, and picking "Retried in the last 2 Hours" narrows the range to two hours. Since they drive the real dropdown, they will also fail ifselectedQueueever becomes readonly again.Reviewer Checklist