Repository navigation
All Messages view no longer disabled during slow queries - #3105
Conversation
johnsimons
left a comment
There was a problem hiding this comment.
@ramonsmits I noticed that there is some extra repainting going on. It seems to redraw the whole screen.
Here is a comparison of the before (left) and after (right), using both Chrome and Safari.
Sep-07-2026.17-26-35.mp4
But overall looks good, although I am not sure about the countdown progress bar. I think I would prefer a text, and quite possible that would also be better for screen reader if we do efven support them!
Good find
True, that bar isn't there anymore. It is now an animation within the refresh button. However, due to the stacked PRs that isn't visible here. |
b6c4c60 to
c99f6d7
Compare
c99f6d7 to
bd8b673
Compare
johnsimons
left a comment
There was a problem hiding this comment.
I am approving this becasue I know quite a few other changes have been done in the next PRs
249c249 to
d1b318c
Compare
d1b318c to
7257aa0
Compare
… out ServiceControl now terminates audit queries that exceed the configured query time limit. Previously any failed query left the view silently empty (the error became an unhandled watcher rejection). The store now records the failure and the view shows an alert explaining that the instance might be too busy, with concrete suggestions: retry off-peak, reduce the maximum results, or narrow the date range.
The filter inputs were disabled while a query ran, which lost the focus after one typed character and locked users out for the duration of a slow query; every re-fetch also covered the list with a white overlay (#3047), so on every auto-refresh tick the rows flashed and became unreachable. The controls now stay enabled; starting a query aborts the one still in flight (the abort propagates through ServiceControl and terminates the database-side query) instead of silently dropping the new request, and a superseded response can no longer overwrite newer results. A re-fetch over existing rows leaves them visible and usable until the new results replace them; the plain spinner remains only when there is nothing to show yet.
…tdown When the auto-refresh period is shorter than the query duration, a tick that lands mid-query no longer disappears: the running query is left undisturbed (not cancelled) and the refresh runs as soon as its results are in. A thin countdown bar under the refresh controls now depletes towards the next auto refresh, and pulses while a due refresh is waiting on a running query, so it is always visible when the view will update.
The controls watcher bailed out during the first load, so a search typed while the initial (possibly minutes-long) query was still running was silently ignored: nothing was pushed to the route, the running query was not superseded, and no new query started. The first-load bail-out is replaced with an idempotence check: the watcher only pushes when the controls differ from the state the route last applied, which both suppresses the mount-time watcher replay the old guard was protecting against and lets a real user change through at any time.
Navigating away aborts the in-flight query (server-side included) and releases the auto-refresh registration, so a backgrounded view keeps no load on the server. The rows live in the store, which outlives the view, so coming back showed the previous visit's rows under the first-load spinner; the store now forgets the results, the total and any failure when the view is left, and the next visit starts from a clean list.
7257aa0 to
9067f35
Compare
Stacked on:
Five fixes that make the All Messages view behave when queries are slow (large audit stores):
Related: