Repository navigation
Fix saving notification settings on RavenDB databases from 6.19 - #5925
Merged
warwickschroeder merged 1 commit intoSep 25, 2026
Merged
Conversation
…add corresponding tests
johnsimons
approved these changes
Sep 25, 2026
rbev
approved these changes
Sep 25, 2026
warwickschroeder
deleted the
warwick/notifications-save-collection-mismatch
branch
September 25, 2026 06:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Since 6.20, saving email notification settings fails every time on a RavenDB database that saved them on 6.19 or earlier. This fix does not move old documents into the new collection; they stay where they are and keep working.
NotificationsSettings, soNotificationsSettings/Allsits in theNotificationsSettingscollection.NotificationsSettingsDocument, whose collection isNotificationsSettingsDocuments.DocumentCollectionMismatchException.500, and ServicePulse shows UPDATE FAILED. Loading still works.Tests
ServiceControl.Persistence.Tests.RavenDB: a new test seeds the document in the oldNotificationsSettingscollection and saves over it. It fails onmasterwith the exception and passes with the fix.ServiceControl.AcceptanceTests.RavenDB: the existing notification tests still pass.500and show UPDATE FAILED; after it, both return200and the settings survive a reload.