Repository navigation
Serve an ingestion-only worker over HTTPS with its certificate - #5923
Merged
Merged
Conversation
rbev
approved these changes
Sep 25, 2026
johnsimons
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
With HTTPS enabled, an ingestion-only worker bound
https://without handing its certificate to Kestrel, so it failed to start on a server and served the development certificate on a developer machine. It now serves the configured certificate, like every other host. HTTPS redirect and HSTS still do not apply to the worker.Tests
ServiceControl.AcceptanceTests/Recoverability/When_hosting_error_ingestion_only: starts the worker over HTTPS and checks it serves the configured certificate. Fails without the fix; runs on PostgreSQL and SQL Server.