Let SQL Server and PostgreSQL primaries be upgraded - #5921
Merged
Merged
Conversation
…e validation - Introduced UpgradeMaintenancePortTests to verify maintenance port settings for primary persisters. - Added TryStopServiceTests to ensure service stops correctly when files are locked. - Created StorageEngineUpgradeTests to validate upgrade capabilities of primary and audit storage engines. - Updated BaseService to extend wait time for service stop operations. - Refactored AbstractCommandChecks to improve upgrade compatibility checks for storage engines.
johnsimons
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
SCMU and the PowerShell module refused to upgrade any primary not on RavenDB, and an upgrade could fail when a stopped instance took more than 5 seconds to release its files. Both now go through. Neither tool can create a SQL Server or PostgreSQL primary yet, and
-Forceis unchanged.Tests
ServiceControlInstaller.Engine.UnitTests/Validation/StorageEngineUpgradeTests(new): which shipped primary and audit storage engines can be upgraded.ServiceControlInstaller.Engine.UnitTests/Services/TryStopServiceTests(new): a stop succeeds when a DLL stays locked for 7 seconds.ServiceControl.Config.Tests/UpgradeMaintenancePortTests(new): which primary storage engines are asked for a maintenance port.