Add Complete() method to IAuditIngestionUnitOfWork - #5918
Merged
Merged
Conversation
johnsimons
approved these changes
Sep 24, 2026
rbev
marked this pull request as ready for review
September 25, 2026 05:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
Completemethod to theIAuditIngestionUnitOfWorkinterface and implements it across all audit ingestion unit of work classes.Why
As preparation work for implementing audit ingestion on entity framework, this aligns the ingestion unit of work with it's sibling for error ingestion in the Primary instance.
While the current RavenDB ingestor makes use of a
BulkInsertOperationthat does not provide a full transactional rollback the upcoming SQL pipeline will.API and Interface Changes
Complete(CancellationToken cancellationToken = default)method to theIAuditIngestionUnitOfWorkinterface to signal when all records have been added and the unit of work should commit.Completemethod in bothInMemoryAuditIngestionUnitOfWork(as a no-op, since writes are immediate) andRavenAuditIngestionUnitOfWork(which flushes and disposes the bulk insert, ensuring all records are written). [1] [2]AuditPersisterto callunitOfWork.Complete()after persisting audit records, ensuring the commit point is respected.await usingfor proper disposal and replaced explicitDisposeAsync()calls with the newComplete()method, improving resource management and consistency with the new API.