Fix ingestion-only worker setup and default concurrency - #5917
Merged
Merged
Conversation
johnsimons
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
An ingestion-only worker started with
--setup-and-runran the primary's full setup, and one started without a concurrency setting failed to start. Setup now refuses a worker, and a worker defaults to a concurrency of 10 like the primary. The refusal still prints a stack trace.--setupand--setup-and-runrefuse when combined with--error-ingestion-only, before provisioning anything.Tests
ServiceControl.UnitTests/Hosting(new): argument parsing keeps the worker flag, and setup refuses a worker.ServiceControl.AcceptanceTests/Recoverability/When_hosting_error_ingestion_only: a worker with no concurrency setting starts and receives with 10, on PostgreSQL and SQL Server.