Conversation
Co-authored-by: afprtclr <208591451+afprtclr@users.noreply.github.com>
Co-authored-by: afprtclr <208591451+afprtclr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor interception helper to use SpyEndpoints pattern
Replace Audit interception helper with spy endpoints
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Audit acceptance tests were verifying messages to the primary ServiceControl instance by intercepting outgoing pipeline operations instead of observing delivery at the destination. This updates those tests to use the repository’s established spy-endpoint pattern and removes the now-obsolete interception support.
What changed
ServiceControlQueueAddressat a per-test spy endpoint.RegisterNewEndpointhandlers that record what actually arrives at the primary destination queue.Tests updated
Monitoring/When_a_new_endpoint_is_detectedRecoverability/When_importing_a_message_resolved_by_a_retryTest support cleanup
InterceptMessagesDestinedToServiceControlInterceptedMessagesScenarioContextSpy endpoint pattern
RegisterNewEndpointin scenario context.