Remove OverrideCustomCheckRepeatTime from PersistenceSettings and related test configuration - #5912
Merged
warwickschroeder merged 1 commit intoSep 22, 2026
Conversation
…ated test configuration
johnsimons
approved these changes
Sep 21, 2026
warwickschroeder
deleted the
warwick/remove-dead-custom-check-repeat-time
branch
September 22, 2026 03:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this removes
PersistenceSettings.OverrideCustomCheckRepeatTimehas had no reader since #4147 and this deletes it, along with the one acceptance test line that still set it. No custom check changes its repeat time, because none of them ever consulted this property.PersistenceSettingsis the base every persister derives from, so a public property there reads as part of the host-to-persister contract. This one meant nothing: every custom check that ships passes a literal interval to itsCustomCheckbase constructor, six inServiceControl.Persistence.RavenDB, five inServiceControl.Audit.Persistence.RavenDBandFileSystemBodyStorageCustomCheckin the EF persister.SagaAuditDestinationCustomCheck, which tooksettings.OverrideCustomCheckRepeatTime ?? TimeSpan.FromMinutes(15)as its interval. Simplify the primary instance SagaAudit data store #4147 deleted that check and one of the two test lines that set the override, and left the property and the other test line behind.When_remote_instance_is_not_reachableset the override to two seconds, so it read as though it had made the custom checks run every two seconds. It had not. The test keeps both of itsdisableHealthCheckscases and every assertion, which is what it was actually written to cover.ConfigurationApiserialises the whole settings object intoGET /api/configuration, sooverrideCustomCheckRepeatTimecurrently ships to ServicePulse as a null field and disappears from that payload. Nothing asserts on the shape of that response and ServicePulse reads fields by name.Tests
ServiceControl.MultiInstance.AcceptanceTests:When_remote_instance_is_not_reachableloses the line but keeps both cases, so it still covers that an unreachable remote instance does not fail a search.