Move hardcoded rowlimit out of the storage implementation - #5899
Merged
Merged
Conversation
warwickschroeder
approved these changes
Sep 16, 2026
Member
|
It is unclear to me what is the benefit of moving the cheese this way. I think a better option, is to document what we spoke about in the slack thread in the code itself. |
Contributor
|
@johnsimons - i think im missing context here. Could you elaborate on what the other factors are? |
rbev
force-pushed
the
move-200-limit
branch
from
September 17, 2026 04:19
4d4cb0c to
b1efad1
Compare
rbev
force-pushed
the
move-200-limit
branch
from
September 17, 2026 04:25
ae3d48d to
ecb4762
Compare
warwickschroeder
approved these changes
Sep 17, 2026
johnsimons
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the existing 200-group limit from persistence implementation into the API, changed it to explicitly request a single 200 group page instead of relying the the storage tier to limit it.
PagingInfoto unresolved and archived group-list datastore methods..Take(200)calls andFailureGroupQueries.MaxGroups.GroupFetchermerge behavior.