Skip to content

Move hardcoded rowlimit out of the storage implementation - #5899

Merged
rbev merged 5 commits into
masterfrom
move-200-limit
Sep 18, 2026
Merged

rbev merged 5 commits into
masterfrom
move-200-limit

Conversation

@rbev

@rbev rbev commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Moves the existing 200-group limit from persistence implementation into the API, changed it to explicitly request a single 200 group page instead of relying the the storage tier to limit it.

  • Adds PagingInfo to unresolved and archived group-list datastore methods.
  • Requests page 1 with a page size of 200 from both APIs
  • Applies paging within RavenDB and EF Core queries.
  • Removes persistence-owned .Take(200) calls and FailureGroupQueries.MaxGroups.
  • Adds shared contract tests for unresolved and archived group paging.
  • Preserves existing response metadata and GroupFetcher merge behavior.

Comment thread src/ServiceControl.Persistence.Tests/Recoverability/ArchivedGroupVersionTests.cs Outdated
@johnsimons

Copy link
Copy Markdown
Member

It is unclear to me what is the benefit of moving the cheese this way.
I actually think that the next person touching this will look at it and say, ah the api already supports paging, so let me add paging to the frontend! Without really taking into consideration lots of other factors.

I think a better option, is to document what we spoke about in the slack thread in the code itself.

@warwickschroeder

Copy link
Copy Markdown
Contributor

@johnsimons - i think im missing context here. Could you elaborate on what the other factors are?

@rbev
rbev merged commit bf51892 into master Sep 18, 2026
69 of 70 checks passed
@rbev
rbev deleted the move-200-limit branch September 18, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants