Repository navigation
Refactor persistence manifest handling and add unit tests for loading behavior - #5867
Merged
Merged
Conversation
rbev
approved these changes
Sep 9, 2026
johnsimons
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An instance configured for SQL Server will not start. It dies with
Could not load persistence customization type SQLServer.over aNullReferenceException.No released version is affected.
What is wrong
PersistenceManifestLibraryreads everyPersisters\<Name>\persistence.manifestin one loop wrapped by a singletry, so the first file that throws discards every file after it, logged as a warning and nothing more.The file that throws is
RavenDB35. Its manifest has noAssemblyNameorTypeName, correctly, because there is no assembly left to load, but the model marked bothrequiredandSystem.Text.Jsonrejects it. Folders are read in name order, soRavenDB35throws third andSQLServeris never read.PostgreSQLsorts earlier and survives, which is what makes it look SQL-Server-specific.It is invisible from a source checkout, where manifests come from
DevelopmentPersistenceLocationsand RavenDB 3.5 never appears. Only a real install shows it.The fix
try/catchin a newLoadManifests, so a bad manifest costs you that manifest and nothing else.AssemblyNameandTypeNameare nullable again.Name,DisplayNameandDescriptionkeeprequired.Tests
Two tests, one per defect, staging a real install layout in a temp directory. Each half of the fix was reverted separately to confirm the matching test goes red.