Repository navigation
Stop persisting computed ETag fields into RavenDB documents - #5838
Merged
Merged
Conversation
johnsimons
approved these changes
Sep 1, 2026
rbev
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IVersionedRow.VersionFieldsis a computed property that exists only to feed ETag computation, but RavenDB's serialiser persists it into the stored documents. It appears wherever a type is both the storage shape and the API row shape, which isCustomCheckand the two retry-operation types nested insideRetryHistory. This changes the member from a property to a method,GetVersionFields(): serialisers do not serialise methods, so the problem cannot recur on any type or any serialiser.