Repository navigation
Convert notification settings manager to use atomic reads/writes - #5762
Merged
Merged
Conversation
johnsimons
approved these changes
Aug 13, 2026
rbev
force-pushed
the
rhys/atomic-commit
branch
4 times, most recently
from
August 14, 2026 03:51
4d6cf1c to
fb42b2a
Compare
rbev
force-pushed
the
rhys/atomic-commit
branch
from
August 14, 2026 05:09
fb42b2a to
16a649e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the notifications settings persistence layer to simplify its interface and implementation, removing the
INotificationsManagerabstraction in favor of directLoadSettingsandSaveSettingsmethods onINotificationsDataStore. It also updates the tests to match the new API and adds cancellation support. The changes affect both EFCore and RavenDB persistence implementations, as well as their respective test suites.Persistence Layer Refactoring
INotificationsManagerabstraction and its implementations (NotificationsManagerfor both EFCore and RavenDB), replacing them with directLoadSettingsandSaveSettingsmethods onINotificationsDataStore. This simplifies how notification settings are loaded and saved throughout the codebase. [1] [2] [3] [4]INotificationsDataStoreto provide the new methods, ensuring settings are loaded and saved directly via the data store. [1] [2]Test Suite Updates
LoadSettingsandSaveSettingsAPI instead of the removed manager abstraction, and added tests to verify cancellation token propagation. [1] [2]Application Code Updates
SetupNotificationSettingsclass in acceptance tests to use the newLoadSettingsandSaveSettingsmethods directly, reflecting the removal of the manager abstraction.