Repository navigation
Propagate cancellation tokens through failed message editing and notification persistence - #5743
Merged
Merged
Conversation
rbev
approved these changes
Aug 12, 2026
johnsimons
force-pushed
the
john/cancel_part11
branch
from
August 12, 2026 02:53
0e2cd54 to
ad0c132
Compare
johnsimons
force-pushed
the
john/cancel_part11
branch
from
August 12, 2026 03:30
ad0c132 to
4cafc50
Compare
…fication persistence This change continues the effort to consistently apply optional `CancellationToken` parameters to asynchronous methods within the `IEditFailedMessagesDataStore`, `INotificationsDataStore`, and related manager interfaces, along with their EFCore and RavenDB implementations. Cancellation tokens are now propagated to underlying asynchronous database calls, ensuring proper cancellation of long-running operations.
johnsimons
force-pushed
the
john/cancel_part11
branch
from
August 12, 2026 03:41
4cafc50 to
ae75967
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change continues the effort to consistently apply optional
CancellationTokenparameters to asynchronous methods within theIEditFailedMessagesDataStore,INotificationsDataStore, and related manager interfaces, along with their EFCore and RavenDB implementations.Cancellation tokens are now propagated to underlying asynchronous database calls, ensuring proper cancellation of long-running operations.