Repository navigation
Propagate cancellation tokens through ingestion and body storage pers… - #5742
Merged
Merged
Conversation
rbev
approved these changes
Aug 12, 2026
johnsimons
force-pushed
the
john/cancel_part10
branch
from
August 12, 2026 02:53
3caeeeb to
f3a3396
Compare
…istence This change continues the effort to consistently apply optional `CancellationToken` parameters to asynchronous methods within the `IBodyStorage`, `IFailedErrorImportDataStore`, and ingestion unit of work interfaces, along with their EFCore and RavenDB implementations. Cancellation tokens are now propagated to underlying asynchronous database calls, ensuring proper cancellation of long-running operations. In the error processor, specific handling for `OperationCanceledException` was added to ensure message contexts are released during shutdown so that the ingestion loop can terminate rather than awaiting indefinitely.
johnsimons
force-pushed
the
john/cancel_part10
branch
from
August 12, 2026 03:30
f3a3396 to
fbd14db
Compare
…tore Pass the cancellation token to the body storage fetch operation to ensure proper cancellation of database calls during failed message body retrieval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change continues the effort to consistently apply optional
CancellationTokenparameters to asynchronous methods within theIBodyStorage,IFailedErrorImportDataStore, and ingestion unit of work interfaces, along with their EFCore and RavenDB implementations.Cancellation tokens are now propagated to underlying asynchronous database calls, ensuring proper cancellation of long-running operations. In the error processor, specific handling for
OperationCanceledExceptionwas added to ensure message contexts are released during shutdown so that the ingestion loop can terminate rather than awaiting indefinitely.