Repository navigation
Propagate cancellation tokens through the archiving operations - #5741
Merged
Merged
Conversation
rbev
approved these changes
Aug 12, 2026
This change continues the effort to consistently apply optional `CancellationToken` parameters to asynchronous methods within `IArchiveMessages`, the in-memory archive and unarchive operations, the archiving and unarchiving managers, the RavenDB document managers, and both `MessageArchiver` implementations, along with the controllers and handlers that consume them. Cancellation tokens are now propagated to the underlying asynchronous database calls and to the domain events raised as an operation progresses, which retires eight `CancellationToken.None` arguments that existed only because no token reached that far. The wait-for-index calls in both RavenDB document managers now rethrow cancellation ahead of their catch-all, so a shutdown is no longer reported as an index that failed to catch up. No `.editorconfig` suppressions are removed here, because every rule in these projects still has violations from the interface groups that remain.
johnsimons
force-pushed
the
john/cancel_part9
branch
from
August 12, 2026 02:53
81555f2 to
5ab15f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change continues the effort to consistently apply optional
CancellationTokenparameters to asynchronous methods within
IArchiveMessages, the in-memory archive and unarchive operations, the archiving and unarchiving managers, the RavenDB document managers, and bothMessageArchiverimplementations, along with the controllers and handlers that consume them.Cancellation tokens are now propagated to the underlying asynchronous database calls and to the domain events raised as an operation progresses, which retires eight
CancellationToken.Nonearguments that existed only because no token reached that far.The wait-for-index calls in both RavenDB document managers now rethrow cancellation ahead of their catch-all, so a shutdown is no longer reported as an index that failed to catch up. No
.editorconfigsuppressions are removed here, because every rule in these projects still has violations from the interface groups that remain.