Repository navigation
Continue cancellation token propagation in audit persistence layer - #5736
Merged
Merged
Conversation
johnsimons
force-pushed
the
john/cancel_part6
branch
from
August 11, 2026 07:16
cbc2e7e to
9df53e8
Compare
johnsimons
marked this pull request as ready for review
August 11, 2026 07:17
johnsimons
force-pushed
the
john/cancel_part6
branch
from
August 11, 2026 07:17
9df53e8 to
ad2d2ce
Compare
johnsimons
force-pushed
the
john/cancel_part6
branch
from
August 11, 2026 10:37
ad2d2ce to
1e37de7
Compare
This change expands the consistent application of optional `CancellationToken` parameters to asynchronous methods within the audit persistence interfaces and their InMemory and RavenDB implementations. Cancellation tokens are now propagated to underlying asynchronous database calls and consuming services. This ensures proper cancellation of long-running operations and further reduces cancellation analyzer debt by removing suppressions from related `.editorconfig` files.
johnsimons
force-pushed
the
john/cancel_part6
branch
from
August 11, 2026 11:55
1e37de7 to
99f8e79
Compare
rbev
approved these changes
Aug 12, 2026
| # WaitForLicenseOrThrow passes only the linked cts.Token into its try, so PS0020 cannot recognise a | ||
| # filter on the caller's token. Removing this needs the license-check exception mapping reworked, not | ||
| # a token added, so it is deliberately scoped to the one file rather than the project. | ||
| [LicenseStatusCheck.cs] |
Contributor
There was a problem hiding this comment.
shouldn't the problematic file just get a #pragma instead?
Member
Author
There was a problem hiding this comment.
I think Claude is doing it this way.
When we're done, hopefully there is nothing left in the .editorconfig files.
|
|
||
| # Justification: the polling loop swallows OperationCanceledException on purpose, because querying an | ||
| # index at the moment it updates throws one. That is not cancellation, so there is no token to filter on. | ||
| [IndexSetupTests.cs] |
Contributor
There was a problem hiding this comment.
shouldn't the problematic file just get a #pragma instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change expands the consistent application of optional
CancellationTokenparameters to asynchronous methods within the audit persistence interfaces and their InMemory and RavenDB implementations.Cancellation tokens are now propagated to underlying asynchronous database calls and consuming services. This ensures proper cancellation of long-running operations and further reduces cancellation analyzer debt by removing suppressions from related
.editorconfigfiles.