Repository navigation
Implement retry failure store - #5730
Merged
Merged
Conversation
johnsimons
approved these changes
Aug 11, 2026
johnsimons
left a comment
johnsimons
left a comment
Member
There was a problem hiding this comment.
Looks fine, just a small comment regarding allocations
| } | ||
| await using (result.Stream) | ||
| { | ||
| using var memoryStream = new MemoryStream(); |
Member
There was a problem hiding this comment.
Is there a way to avoid this allocation? We may need to change the signature!
Contributor
Author
There was a problem hiding this comment.
It's also missing the in-table body storage logic
Contributor
Author
There was a problem hiding this comment.
After additional investigation this is fine, but this method may be better off being removed in favor of directly using IBodyStorage at the call site.
rbev
force-pushed
the
rhys/retry-failures
branch
from
August 12, 2026 01:43
b7f7800 to
140f024
Compare
rbev
enabled auto-merge
August 12, 2026 01:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the EF Core-backed
FailedMessageRetryDataStorewith full support for retry claim management and message body retrieval, replacing previous stubs. It also adds tests to verify the new behaviors, ensuring correct and idempotent handling of retry and message bodies.EF Core Data Store Implementation:
FailedMessageRetryDataStore, includingRemoveFailedMessageRetry,GetRetryPendingMessages,ProcessPendingRetries, andGetFailedMessageBody, using efficient EF Core queries and ensuring correct, idempotent behavior in line with RavenDB semantics.GetFailedMessageBodynow fetches message bodies from external storage when needed and throws clear exceptions for missing bodies or invalid requests.Testing Enhancements:
FailedMessageRetryDataStoreTestsFailedMessageRetryBodyDataStoreTests