Repository navigation
Implement email notification config on top of config store - #5720
Merged
Merged
Conversation
johnsimons
approved these changes
Aug 10, 2026
rbev
force-pushed
the
rhys/notifications2
branch
from
August 11, 2026 01:10
d95022b to
57566c6
Compare
rbev
enabled auto-merge
August 11, 2026 01:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the notifications data store and manager for the EFCore persistence layer, enabling notifications settings to be loaded and saved using the database context. It also updates related infrastructure and cleans up unused test references.
Notifications infrastructure implementation
NotificationsDataStoreandNotificationsManagerclasses to support loading and saving notification settings using the EFCore database context (ServiceControlDbContext). This includes proper resource disposal and dependency injection support. [1] [2]NotificationEmailsto theSettingKeysclass for storing notification email settings.