Skip to content

Remove unused search method - #5657

Merged
rbev merged 1 commit into
masterfrom
rhys/unused-code
Jul 28, 2026
Merged

rbev merged 1 commit into
masterfrom
rhys/unused-code

Conversation

@rbev

@rbev rbev commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This pull request removes the search functionality for queue addresses from the codebase, including the associated API endpoint, service methods, and tests.

A search of the Particular github turned up no usages of this endpoint across any repositories.

The most important changes include:

API and Controller Changes

  • Removed the /errors/queues/addresses/search/{search} API endpoint from QueueAddressController, including its route, handler method, and related authorization attributes. [1] [2]
  • Updated the namespace declaration style in QueueAddressController.cs to use file-scoped namespaces.

Service and Interface Changes

  • Removed the GetAddressesBySearchTerm method from the IQueueAddressStore interface and its implementations in both the EFCore and RavenDB persistence layers. [1] [2] [3]

Test Changes

  • Deleted the test Should_only_return_queueaddresses_that_startswith_search from the acceptance tests, as the search feature is no longer supported.

@johnsimons johnsimons left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@rbev
rbev merged commit e3e5a14 into master Jul 28, 2026
71 of 72 checks passed
@rbev
rbev deleted the rhys/unused-code branch July 28, 2026 05:04
@rbev rbev mentioned this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants