Fix macOS unoptimised builds - #293
Open
mnightingale wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the macOS builds are scalar only so very slow.
Autoconf only injects its default
-g -O2when CXXFLAGS is unset, so because env is set we end up with unoptimised builds.The universal matrix also drops all ARM SIMD because of
-arch x86_64 -arch arm64, the solution is to build them separately and uselipoto turn them into a universal binary.I went with
-O3but it should probably be updated throughout.I didn't add
-gbecause we strip them immediately afterwords, so I wasn't sure if it would do anything.Any opinion on updating the build tooling to CMAKE?
Unrelated changes:
make -j"$(nproc)"speed up the builds a little<PlatformToolset>v145</PlatformToolset>because windows-latest has changed and doesn't have v143Identified:
I believe the Windows tests especially are slow because printing to the console every 0.1% is slow, I'll send another PR after that throttles it and fixes some issues - it cut 5 minutes off the Windows test time