Repository navigation
fix: validate split sum, product description, claim reference uniqueness, and admin zero address - #758
Merged
nonsobethel0-dev merged 1 commit intoOct 20, 2026
Conversation
…ess, and admin zero address Closes Parashield-Protocol#756 Closes Parashield-Protocol#755 Closes Parashield-Protocol#754 Closes Parashield-Protocol#753
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request resolves four issues across the Parashield contracts:
RiskPool Premium Split Validation ([bug] RiskPool does not validate premium split sum equals 10000 bps #756):
lp_bps + treas_bps + backstop_bps) strictly equals 10,000 bps (100%) inexecute_parameter_change.PolicyEngine Product Description Validation ([bug] PolicyEngine does not validate product description is not empty #755):
params.nameis non-empty and has a valid minimum character length increate_product.EmptyDescriptionandInvalidDescriptionerror variants to prevent uninformative products.ClaimsProcessor Claim Reference Uniqueness ([bug] ClaimsProcessor does not validate claim reference number is unique #754):
submit_claim_with_refentrypoint andStorageKey::ClaimReference(Symbol)tracking.Error::DuplicateClaimReference.RiskPool Zero Address Admin Validation ([security] RiskPool does not validate admin address is not the zero address #753):
require_not_zero_addresson admin address during pool initialisation (initialize), admin rotation proposal (propose_new_admin), and acceptance (accept_admin).Closes #756
Closes #755
Closes #754
Closes #753