Skip to content

Harden oracle, disputes, LP IDs, and delegation - #715

Merged
nonsobethel0-dev merged 1 commit into
Parashield-Protocol:mainfrom
JamesVictor-O:fix/assigned-security-issues
Oct 20, 2026
Merged

nonsobethel0-dev merged 1 commit into
Parashield-Protocol:mainfrom
JamesVictor-O:fix/assigned-security-issues

Conversation

@JamesVictor-O

Copy link
Copy Markdown
Contributor

Summary

  • require an independent guardian and a 48-hour timelock for policy oracle rotations
  • enforce a one-hour to 30-day claim dispute window, defaulting to seven days and rejecting zero
  • stop LP NFT minting with a typed overflow error when the u64 ID space is exhausted
  • identify and reject circular governance delegation before state changes
  • document all four security rules and restore the contract entry points replaced by placeholders in upstream main

Verification

  • cargo check --lib -p parashield-policy-engine -p parashield-claims-processor -p parashield-risk-pool -p parashield-governance-dao
  • cargo test -p parashield-policy-engine --test oracle_rotation (2 passed)
  • cargo test -p parashield-claims-processor --test dispute_window (1 passed)
  • cargo test -p parashield-governance-dao circular_delegation_is_refused (1 passed)
  • cargo test -p parashield-risk-pool lp_nft_id_exhaustion_fails_with_overflow (1 passed)

Upstream baseline note

Upstream main currently replaces four contract lib.rs files with one-line placeholders. This PR restores their immediate-parent implementations so the assigned fixes can compile. The full legacy unit suite also contains pre-existing malformed policy fixtures (missing expected_token / payment-token arguments); focused integration tests are used above and pass.

Closes #677
Closes #678
Closes #679
Closes #680

@drips-wave

drips-wave Bot commented Oct 20, 2026

Copy link
Copy Markdown

@JamesVictor-O Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@nonsobethel0-dev
nonsobethel0-dev merged commit 63aa12e into Parashield-Protocol:main Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants