Repository navigation
fix: guard risk-pool withdrawals when capital is drained - #710
Merged
nonsobethel0-dev merged 1 commit intoOct 19, 2026
Merged
nonsobethel0-dev merged 1 commit into
nonsobethel0-dev merged 1 commit into
Conversation
|
@iamcracked-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #668
Closes #648
Closes #649
Closes #650
Summary
This pull request makes the fully utilized and drained risk-pool state explicit during LP redemption. When all deposited capital is locked, there is no valid share price or withdrawable liquidity to calculate, so the contract now returns a dedicated typed error instead of treating the condition as a generic collateral failure.
Issue #668: Guard drained-pool withdrawals
Assigned issue references
The description includes both assigned Parashield Contracts issues: #668 and #648. The implementation is focused on the drained-pool behavior described by #668; the existing source already contains the disputed-claim status guard associated with #648.
Verification
Not run, per request. No installation, build, test, or CI check was performed.