Repository navigation
fix: validate product name is not empty in create_product - #709
Merged
nonsobethel0-dev merged 2 commits intoOct 19, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #636
Closes #637
Closes #638
Closes #639
What changed
EmptyProductNameerror variant and validate product name is not empty inPolicyEngine.create_productWhy
create_productaccepted empty product names, making products indistinguishableHow to test
create_productwith an emptynamesymbol — should panic withEmptyProductNamecreate_productwith a valid non-empty name — should succeedcargo test -p parashield-policy-engine(100 passed)