Skip to content

fix(claims-processor): validate escalate_claim only accepts Pending check - #707

Merged
nonsobethel0-dev merged 1 commit into
Parashield-Protocol:mainfrom
MissHarah:fix/628-escalate-claim-pending-status-validation
Oct 20, 2026
Merged

nonsobethel0-dev merged 1 commit into
Parashield-Protocol:mainfrom
MissHarah:fix/628-escalate-claim-pending-status-validation

Conversation

@MissHarah

Copy link
Copy Markdown
Contributor

…laims (Parashield-Protocol#628)

- escalate_claim already guards with ClaimStatus::Pending check; this
  commit hardens the surrounding code that was preventing compilation:
  * Add policy_engine() private helper (was called but undefined)
  * Add get_product() to IPolicyEngine cross-contract client trait
  * Add InvalidClaimAmount (=33) and DisputeReasonTooLong (=34) to Error enum
  * Fix dispute_claim event: use caller.clone() instead of undefined claimant
- Fix test.rs: remove ~370 duplicate lines (lines 724-1092 were an
  accidental copy-paste of lines 360-726), fix two stacked attribute pairs
- Add four targeted tests for issue Parashield-Protocol#628:
  * rejected_claim_cannot_be_escalated
  * disputed_claim_cannot_be_escalated
  * escalated_claim_cannot_be_escalated_again
  * partially_paid_claim_cannot_be_escalated
  All four assert NotEscalatable (Parashield-Protocol#17) for non-Pending status
@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@MissHarah Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@nonsobethel0-dev
nonsobethel0-dev merged commit c9435db into Parashield-Protocol:main Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] PolicyEngine does not validate coverage_min > 0 [security] ClaimsProcessor does not validate escalation claim status is Pending

2 participants