Repository navigation
fix: handle corrupted Redis cache entries as cache misses (#736) - #800
Merged
nonsobethel0-dev merged 1 commit intoOct 19, 2026
Conversation
|
@daniella-techie Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
nonsobethel0-dev
merged commit Oct 19, 2026
0095a29
into
Parashield-Protocol:main
0 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes how the Redis-backed idempotency response cache (
src/common/middleware/idempotency.middleware.ts) handles corrupted entries.Before this change, a corrupted entry was skipped but never removed. An entry that parsed as JSON but had the wrong shape (for example
null, a missingbody, or an invalidstatus) could also make the replay fail after headers had already been written.Changes
parseCachedEntryhelper, and its result is checked before use: it must be an object with abodyand an integer HTTPstatusfrom 100 to 599.falsefromreplayCached, so the request goes through the normal lock-and-handle flow.DEL. If the delete itself fails, a warning is logged and the request still goes ahead. The handler's fresh 2xx response then replaces the entry.null, a missing body, a non-numeric status and an out-of-range status, plus a failingDEL.Test plan
npx jest src/common/middleware/idempotency.middleware.spec.ts: 10/10 passingCloses #735
Closes #736
Closes #737
Closes #738