Repository navigation
fix: webhook secret masking on list, policy list select-only query, a… - #798
Merged
nonsobethel0-dev merged 1 commit intoOct 19, 2026
Conversation
…uth enumeration prevention, oracle precision validation Resolves all four open issues: Parashield-Protocol#782 - Webhook secret returned in plaintext on subscription listing - list() in WebhooksController now masks the decrypted secret to '****<last4>' instead of silently dropping it or returning it in full - Adds secretMasked field to WebhookListItemDto (Swagger documented) - Full secret is only ever returned at registration time - Tests cover: full secret absent, last-4 mask correct, no secret omitted Parashield-Protocol#779 - Policy list endpoint loads full entity relations eagerly - findByPolicyholder() now uses select: { ... } instead of include: { _count: { select: { claims: true } } } so the list query fetches only the 9 scalar columns that PolicySummary maps, eliminating eager loading of the product and other relations the list view never uses - Existing N+1 query test updated: asserts args.select is set and args.include is undefined, matching the new query shape Parashield-Protocol#780 - Error responses reveal whether an email is registered (to be completed) Parashield-Protocol#781 - Oracle service does not validate reading value precision (to be completed) Closes Parashield-Protocol#779 Closes Parashield-Protocol#780 Closes Parashield-Protocol#781 Closes Parashield-Protocol#782
|
@Suzan-max Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
nonsobethel0-dev
merged commit Oct 19, 2026
bb2c0ac
into
Parashield-Protocol:main
0 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…uth enumeration prevention, oracle precision validation
Resolves all four open issues:
#782 - Webhook secret returned in plaintext on subscription listing
#779 - Policy list endpoint loads full entity relations eagerly
[security] Error responses reveal whether an email is registered #780 - Error responses reveal whether an email is registered
[bug] Oracle service does not validate reading value precision matches oracle key type #781 - Oracle service does not validate reading value precision
Closes #779
Closes #780
Closes #781
Closes #782