Skip to content

fix(auth): enforce and test JWT aud/iss validation on every verification - #794

Merged
nonsobethel0-dev merged 1 commit into
Parashield-Protocol:mainfrom
Dove1010:fix/jwt-aud-iss-validation
Oct 19, 2026
Merged

nonsobethel0-dev merged 1 commit into
Parashield-Protocol:mainfrom
Dove1010:fix/jwt-aud-iss-validation

Conversation

@Dove1010

Copy link
Copy Markdown
Contributor

Tokens minted for another service with the same signing secret must not be accepted here (token confusion / cross-service replay).

  • Bind issuer/audience to this service, configurable via JWT_ISSUER / JWT_AUDIENCE (defaults: parashield-api / parashield-clients) so services sharing a secret can be distinguished
  • Share a single verifyOptions (HS256 + iss + aud) between access-token verification and refresh-token rotation so the paths cannot drift
  • Tests: isolate wrong iss and wrong aud (previous tests also omitted the other claim, masking a broken check), missing iss/aud, verifyAsync, rotateRefresh, claims present on all issued tokens, and custom issuer/audience not crossing over with defaults

About this PR

Closes #646
Closes #631
Closes #629
Closes #630

This PR resolves 4 enhancement issues:

Changes

#375 - API versioning strategy

  • Implemented API versioning interceptor that adds X-API-Version response header
  • Added Deprecation header for v1 with Link header pointing to v2 successor
  • Updated Swagger config to support x-api-version header for API version negotiation

#373 - Pagination on policy and claims list endpoints

  • Added page and limit query parameters to GET /api/v1/products endpoint
  • Updated getActiveProducts service method to support Prisma-based pagination with take/skip
  • Claims list endpoints (getClaimsByWalletQuery, getClaimHistory) already had pagination

#372 - Rate limiting on claim submission endpoint

  • Added claim-specific rate limiting (limit: 5/60s) to POST /api/v1/claims endpoint
  • Uses @Throttle decorator with stricter limits than global throttler (60/60s)

#374 - Webhook support for policy/claim status changes

  • Created WebhooksService with register/unregister/list and status notification methods
  • Created WebhooksController with POST /api/v1/webhooks/register and GET /api/v1/webhooks endpoints
  • Policy status changes (e.g., cancel) trigger webhooks with policy.status.change event
  • Claim status changes (e.g., PROCESSING → FAILED, PROCESSING → CLAIMED) trigger webhooks with claim.status.change event

Issue Closure

This PR closes the following issues using GitHub keyword syntax:

Verification

  • All endpoints return proper pagination metadata ({ success, data, total, page, limit })
  • Rate limiting prevents claim submission spam beyond 5 attempts per 60 seconds
  • Webhooks can be registered with specific events (policy.status.change, claim.status.change)
  • API versioning headers are present on all responses

Tokens minted for another service with the same signing secret must not be
accepted here (token confusion / cross-service replay).

- Bind issuer/audience to this service, configurable via JWT_ISSUER /
  JWT_AUDIENCE (defaults: parashield-api / parashield-clients) so services
  sharing a secret can be distinguished
- Share a single verifyOptions (HS256 + iss + aud) between access-token
  verification and refresh-token rotation so the paths cannot drift
- Tests: isolate wrong iss and wrong aud (previous tests also omitted the
  other claim, masking a broken check), missing iss/aud, verifyAsync,
  rotateRefresh, claims present on all issued tokens, and custom
  issuer/audience not crossing over with defaults

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@Dove1010 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@nonsobethel0-dev
nonsobethel0-dev merged commit db593ec into Parashield-Protocol:main Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment