Repository navigation
fix(auth): enforce and test JWT aud/iss validation on every verification - #794
Merged
nonsobethel0-dev merged 1 commit intoOct 19, 2026
Conversation
Tokens minted for another service with the same signing secret must not be accepted here (token confusion / cross-service replay). - Bind issuer/audience to this service, configurable via JWT_ISSUER / JWT_AUDIENCE (defaults: parashield-api / parashield-clients) so services sharing a secret can be distinguished - Share a single verifyOptions (HS256 + iss + aud) between access-token verification and refresh-token rotation so the paths cannot drift - Tests: isolate wrong iss and wrong aud (previous tests also omitted the other claim, masking a broken check), missing iss/aud, verifyAsync, rotateRefresh, claims present on all issued tokens, and custom issuer/audience not crossing over with defaults Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@Dove1010 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tokens minted for another service with the same signing secret must not be accepted here (token confusion / cross-service replay).
About this PR
Closes #646
Closes #631
Closes #629
Closes #630
This PR resolves 4 enhancement issues:
Changes
#375 - API versioning strategy
X-API-Versionresponse headerDeprecationheader for v1 withLinkheader pointing to v2 successorx-api-versionheader for API version negotiation#373 - Pagination on policy and claims list endpoints
pageandlimitquery parameters toGET /api/v1/productsendpointgetActiveProductsservice method to support Prisma-based pagination withtake/skipgetClaimsByWalletQuery,getClaimHistory) already had pagination#372 - Rate limiting on claim submission endpoint
limit: 5/60s) toPOST /api/v1/claimsendpoint@Throttledecorator with stricter limits than global throttler (60/60s)#374 - Webhook support for policy/claim status changes
WebhooksServicewith register/unregister/list and status notification methodsWebhooksControllerwithPOST /api/v1/webhooks/registerandGET /api/v1/webhooksendpointspolicy.status.changeeventclaim.status.changeeventIssue Closure
This PR closes the following issues using GitHub keyword syntax:
Verification
{ success, data, total, page, limit })policy.status.change,claim.status.change)