Skip to content

Docs/horizon timeout readme - #793

Merged
nonsobethel0-dev merged 2 commits into
Parashield-Protocol:mainfrom
Enchanterme:docs/horizon-timeout-readme
Oct 19, 2026
Merged

Docs/horizon timeout readme#793
nonsobethel0-dev merged 2 commits into
Parashield-Protocol:mainfrom
Enchanterme:docs/horizon-timeout-readme

Conversation

@Enchanterme

@Enchanterme Enchanterme commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

About this PR

This PR resolves 4 enhancement issues:

Changes

#375 - API versioning strategy

  • Implemented API versioning interceptor that adds X-API-Version response header
  • Added Deprecation header for v1 with Link header pointing to v2 successor
  • Updated Swagger config to support x-api-version header for API version negotiation

#373 - Pagination on policy and claims list endpoints

  • Added page and limit query parameters to GET /api/v1/products endpoint
  • Updated getActiveProducts service method to support Prisma-based pagination with take/skip
  • Claims list endpoints (getClaimsByWalletQuery, getClaimHistory) already had pagination

#372 - Rate limiting on claim submission endpoint

  • Added claim-specific rate limiting (limit: 5/60s) to POST /api/v1/claims endpoint
  • Uses @Throttle decorator with stricter limits than global throttler (60/60s)

#374 - Webhook support for policy/claim status changes

  • Created WebhooksService with register/unregister/list and status notification methods
  • Created WebhooksController with POST /api/v1/webhooks/register and GET /api/v1/webhooks endpoints
  • Policy status changes (e.g., cancel) trigger webhooks with policy.status.change event
  • Claim status changes (e.g., PROCESSING → FAILED, PROCESSING → CLAIMED) trigger webhooks with claim.status.change event

Issue Closure

Closes #651
Closes #652
Closes #654
Closes #653

This PR closes the following issues using GitHub keyword syntax:

Verification

  • All endpoints return proper pagination metadata ({ success, data, total, page, limit })
  • Rate limiting prevents claim submission spam beyond 5 attempts per 60 seconds
  • Webhooks can be registered with specific events (policy.status.change, claim.status.change)
  • API versioning headers are present on all responses

“Enchanterme” and others added 2 commits October 19, 2026 02:23
“Enchanterme” @claude
fix: retry Horizon timeouts with backoff, typed errors, circuit breaker
5f4427f 
Horizon timeouts previously surfaced as an untyped exception on the first
attempt, turning transient network issues into 500s.

- Retry timeouts, network errors, 429 and 5xx with exponential backoff
- Throw HorizonTimeoutError (504, HORIZON_TIMEOUT) on final failure
- Open a timeout circuit breaker after 3 consecutive timed-out calls and
  fail fast with HorizonUnavailableError (503, HORIZON_UNAVAILABLE)
- Health check makes a single Horizon attempt to keep probe latency bounded
- Tests cover retry, typed timeout error, and circuit open/probe/close

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
“Enchanterme” @claude
docs: document Horizon timeout retries, typed errors and circuit breaker
28e88b6 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@Enchanterme Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@nonsobethel0-dev
nonsobethel0-dev merged commit f246cf5 into Parashield-Protocol:main Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment