refactor: Unify set_logical_router with _set_reference pattern#618
Draft
alperenkose wants to merge 1 commit into
Draft
refactor: Unify set_logical_router with _set_reference pattern#618alperenkose wants to merge 1 commit into
alperenkose wants to merge 1 commit into
Conversation
Add parent_type/parent_name support to _set_reference for nested references (LogicalRouter -> Vrf -> interface). Switch _update_reference_in_objects to identity-based skip so non-unique child names (e.g. "default" VRF across LRs) are handled correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An effort to make set_reference to handle nested references and make a single interface for setting references.
Add parent_type/parent_name support to _set_reference for nested references (LogicalRouter -> Vrf -> interface). Switch _update_reference_in_objects to identity-based skip so non-unique child names (e.g. "default" VRF across LRs) are handled correctly.