Repository navigation
feat(ui): mute the full mix during playback and remember the mix per clip - #129
Merged
Merged
Conversation
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branches
feature/,fix/,chore/→devPhase / tâche
v1.4.0 — retour 6 de Palawi : « Mix complet » muet par défaut dans le lecteur
Ce qui change
settings.json→player.mute_full_mix,get_player/set_player).mixde la bibliothèque SQLite (ajoutée aux bases existantes, suit le renommage), commandesclip_mix/set_clip_mix, enregistré 400 ms après le dernier changement et à la fermeture du lecteur ; volume borné côté shell.Critères d'acceptation
Comment ça a été testé
cargo clippy --workspace --all-targets -- -D warnings,cargo test(bibliothèque : état gardé au renommage et au rescan, ancienne base migrée ; shell : volume borné, anciensettings.json→ réglage activé),npm test(7 testsplayerMix.test.ts),npm run buildpwsh scripts/cdp-run.ps1 -Script scripts/player-mix-check.mjs -Clips 3→ 6 sur 6 (piste 1 coupée et export 3/3 ; réactivation et Micro à 30 % retenus ; autre clip coupé ; couper soi-même → export 2/3 ; réglage désactivé → rien de coupé ; export réel d'un clip coupé par le réglage → fichier avec Mix complet, Micro, Discord).Docs mises à jour