Skip to content

Clean up Cargo workspace warnings#51

Open
georgephillips wants to merge 2 commits intomainfrom
cleanup-build-warnings
Open

Clean up Cargo workspace warnings#51
georgephillips wants to merge 2 commits intomainfrom
cleanup-build-warnings

Conversation

@georgephillips
Copy link
Copy Markdown
Contributor

Summary

  • Set resolver = "2" on the workspace root to match the edition 2021 default and silence the resolver version warning.
  • Moved [profile.dev.package.similar] from toolproof/Cargo.toml to the workspace root Cargo.toml, where Cargo actually reads profile configuration.

Context

Running cargo build produced two warnings on every build:

  1. "virtual workspace defaulting to resolver = "1" despite one or more workspace members being on edition 2021 which implies resolver = "2"" -- The workspace root didn't specify a resolver, so Cargo defaulted to v1 despite the member crate using edition 2021.
  2. "profiles for the non root package will be ignored" -- The [profile.dev.package.similar] section in the member crate's Cargo.toml was silently ignored; profile overrides must live in the workspace root.

…d enhanced error logging. Updated BrowserWindow structure to include context ID and browser reference.
@georgephillips georgephillips requested a review from bglw as a code owner April 8, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants