Conversation
prql-bot
left a comment
There was a problem hiding this comment.
task install-pre-commit doesn't exist — there's no such task defined in Taskfile.yaml (or anywhere else in the repo). The original commented-out line had this same nonexistent command, so re-enabling it as-is will cause the postCreateCommand to fail during devcontainer setup.
The setup-dev task (Taskfile.yaml:89) runs pre-commit install-hooks directly — no wrapper task. The devcontainer line should probably just do the same.
The `install-pre-commit` task doesn't exist in Taskfile.yaml. The `setup-dev` task runs `pre-commit install-hooks` directly, so the devcontainer should do the same. Co-Authored-By: Claude <noreply@anthropic.com>
Just install pre-commit so `pre-commit run -a` works, without pre-downloading all hook environments. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@prql-bot why doesn't CI test for the devcontainer? can we adjust this so it does? |
|
The The existing smoke test in Two options to fix this: Option A — Add Option B — Use I'd lean toward Option A as a pragmatic first step — it would have caught the |
|
can we try B? |
Use the devcontainers/ci action to build and test the full devcontainer including features and postCreateCommand. Also add devcontainer.json to the path filter so changes to it trigger the test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Done — added a |
The devcontainer's postCreateCommand runs `task install-maturin` which calls `uv tool install maturin`, but `uv` isn't installed by any devcontainer feature. Install it via pip first. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The Pushed a fix that installs |
pip install fails because the devcontainer Python is marked as externally managed. Use pipx instead, which creates an isolated venv. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
postCreateCommand, which was disabled due to Field Report from using Vite build... #3709 (now closed)install-python-depscommand now runstask install-maturin && task install-pre-commit && pre-commit install-hooksas originally intendedCloses #5768
🤖 Generated with Claude Code